correct git clone command for mangata node #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisli30
approved these changes
Jun 14, 2023
chrisli30
requested changes
Jul 5, 2023
There was a problem hiding this comment.
I think this PR needs a rebase since the master has been updated. @v9n this PR has been in approved state for 3 weeks, we should merge approved PRs in a time manner.
My understanding is that this PR should only include changes to the git clone command.
v9n
force-pushed
the
update-readme-for-mangata-node-compile
branch
from
d0a2c78 to
9b00a75
Compare
|
@chrisli30 my bad, i was using stack PR(multiple PR stack the base on another PR) so they stack on top of each other so when merging it went to this PR. Had I change the base branch when merging it will be cleaner and separate. I'm correct this and other now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a typo in the command to clone a specific branch so I correct it.