Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskCancelled fails silently upon a no-update error #441

Closed
chrisli30 opened this issue Oct 6, 2023 · 0 comments
Closed

TaskCancelled fails silently upon a no-update error #441

chrisli30 opened this issue Oct 6, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@chrisli30
Copy link
Member

chrisli30 commented Oct 6, 2023

When an a non-existent taskId, for example undefined, is passed into cancelTask, TaskCancelled currently fails silently, creating confusion on whether the submitted extrinsics executed or not.

It should throw a regular TaskCancelled event indicating a failed cancellation. For example, ProxyExecuted has a good example that when an error happens, it returns the error instead of the actual result.
CleanShot 2023-10-06 at 10 03 39

@chrisli30 chrisli30 added the question Further information is requested label Oct 6, 2023
@chrisli30 chrisli30 added bug Something isn't working and removed question Further information is requested labels Oct 6, 2023
@v9n v9n closed this as completed in 7959fde Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants