restructure storage, improve task run logic, fixed #441 #446
Conversation
v9n
force-pushed
the
restructure-task-storage
branch
2 times, most recently
from
d46b6b2 to
b79b5e0
Compare
v9n
force-pushed
the
restructure-task-storage
branch
from
b79b5e0 to
87d11aa
Compare
v9n
force-pushed
the
restructure-task-storage
branch
from
87d11aa to
fbd7242
Compare
v9n
changed the title
| @@ -392,10 +403,12 @@ pub mod pallet { | |||
| who: AccountOf<T>, | |||
| task_id: TaskId, | |||
| }, | |||
| Notify { | |||
| message: Vec<u8>, | |||
| }, | |||
| TaskNotFound { | |||
There was a problem hiding this comment.
What’re the differences between TaskDoesNotExsit and TaskNotFound?
There was a problem hiding this comment.
If the usages are similar I suggest to merge them.
There was a problem hiding this comment.
This is overlook. They are just same.
There was a problem hiding this comment.
They are actually a bit different. One is Error, one is an Event.
Error: used when cancel task, if task id not found, we return an error
Event: used when processing task, if a task id not found, we emit an event and continue to normal execution to process other task.
There was a problem hiding this comment.
Gotcha, yeah if they are at difference places, I don’t think we’ll mix them up with the same name. The change looks good.
v9n
changed the title
|
@chrisli30 code update and comment is added |
| @@ -392,10 +403,12 @@ pub mod pallet { | |||
| who: AccountOf<T>, | |||
| task_id: TaskId, | |||
| }, | |||
| Notify { | |||
| message: Vec<u8>, | |||
| }, | |||
| TaskNotFound { | |||
There was a problem hiding this comment.
Gotcha, yeah if they are at difference places, I don’t think we’ll mix them up with the same name. The change looks good.
Improvement over chain storage and underlying data structure, public API of extrinsisc remain unchange.
Changes include:
Refactor Storage
removed AccountTasks
remove ScheduledAssetDeletion
updated Tasks to (account_id, task_id)
add TaskStats and AccountStat to track task count
Task Execution:
Handle task expiration or price moved skipped.
If task has expired by the time it got run, we won't run it,
if price moved by the time the task run, we wo't run it either
Task Scheduling
Introduce MaxTaskPerAccount and MaxTaskOverall limit.