Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): someways is not a noun #708

Merged
merged 1 commit into from
Feb 17, 2025
Merged

fix(core): someways is not a noun #708

merged 1 commit into from
Feb 17, 2025

Conversation

elijah-potter
Copy link
Collaborator

Fixes #704 by fixing the someways dictionary entry that previously declared it a noun.

@elijah-potter elijah-potter added bug Something isn't working harper-core linting labels Feb 17, 2025
@elijah-potter elijah-potter merged commit 4a8b6cd into master Feb 17, 2025
17 checks passed
@elijah-potter elijah-potter deleted the someways-fix branch February 17, 2025 21:48
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 25, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Automattic/harper/harper-ls](/~https://github.com/Automattic/harper) | minor | `v0.20.0` -> `v0.22.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>Automattic/harper (Automattic/harper/harper-ls)</summary>

### [`v0.22.0`](/~https://github.com/Automattic/harper/releases/tag/v0.22.0)

[Compare Source](Automattic/harper@v0.21.1...v0.22.0)

#### What's Changed

-   feat(core): create hyphenation rule for `out-of-date` by [@&#8203;elijah-potter](/~https://github.com/elijah-potter) in Automattic/harper#671
-   chore: use `just sampleforms` to fix curated dict entries by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#660
-   fix: change "and alike" phrase correction to "and the like" by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#705
-   Add Automattic Lingo and Branding by [@&#8203;elijah-potter](/~https://github.com/elijah-potter) in Automattic/harper#706
-   fix(core): possesive -> possessive typo in lint message by [@&#8203;b-sharman](/~https://github.com/b-sharman) in Automattic/harper#690
-   build(deps): bump smallvec from 1.13.2 to 1.14.0 by [@&#8203;dependabot](/~https://github.com/dependabot) in Automattic/harper#694
-   build(deps-dev): bump [@&#8203;types/node](/~https://github.com/types/node) from 22.13.1 to 22.13.4 in /packages by [@&#8203;dependabot](/~https://github.com/dependabot) in Automattic/harper#698
-   build(deps-dev): bump jasmine and [@&#8203;types/jasmine](/~https://github.com/types/jasmine) in /packages by [@&#8203;dependabot](/~https://github.com/dependabot) in Automattic/harper#696
-   build(deps): bump clap from 4.5.28 to 4.5.29 by [@&#8203;dependabot](/~https://github.com/dependabot) in Automattic/harper#695
-   build(deps-dev): bump vite-plugin-top-level-await from 1.4.4 to 1.5.0 in /packages by [@&#8203;dependabot](/~https://github.com/dependabot) in Automattic/harper#699
-   build(deps-dev): bump [@&#8203;sveltejs/adapter-node](/~https://github.com/sveltejs/adapter-node) from 3.0.3 to 5.2.12 in /packages by [@&#8203;dependabot](/~https://github.com/dependabot) in Automattic/harper#700
-   build(deps-dev): bump flowbite from 3.1.1 to 3.1.2 in /packages by [@&#8203;dependabot](/~https://github.com/dependabot) in Automattic/harper#697
-   feat(harper.js): allow modification to the dictionary. by [@&#8203;elijah-potter](/~https://github.com/elijah-potter) in Automattic/harper#683
-   fix(core): `someways` is not a noun by [@&#8203;elijah-potter](/~https://github.com/elijah-potter) in Automattic/harper#708
-   fix(core): make `ChangeTack` lint more specific by [@&#8203;elijah-potter](/~https://github.com/elijah-potter) in Automattic/harper#709

#### New Contributors

-   [@&#8203;b-sharman](/~https://github.com/b-sharman) made their first contribution in Automattic/harper#690

**Full Changelog**: Automattic/harper@v0.21.1...v0.22.0

### [`v0.21.1`](/~https://github.com/Automattic/harper/releases/tag/v0.21.1)

[Compare Source](Automattic/harper@v0.20.0...v0.21.1)

#### What's Changed

-   Proper noun caps australia by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#651
-   feat: Flag "discuss about" instead of "discuss" by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#645
-   feat: suggestion to change "sooner than later" by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#644
-   feat: proper noun capitalization for Malaysia by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#652
-   Implements [#&#8203;505](Automattic/harper#505) could of, should of, would of -> ... have by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#647
-   Remove Duplicate Spelling Suggestions by [@&#8203;elijah-potter](/~https://github.com/elijah-potter) in Automattic/harper#654
-   feat(core): condense `further more` by [@&#8203;elijah-potter](/~https://github.com/elijah-potter) in Automattic/harper#655
-   feat: rename `FullDictionary` -> `MutableDictionary` and add some doc comments by [@&#8203;grantlemons](/~https://github.com/grantlemons) in Automattic/harper#658
-   chore: fixes to curated dictionary affixes by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#650
-   build(deps): bump once_cell from 1.20.2 to 1.20.3 by [@&#8203;dependabot](/~https://github.com/dependabot) in Automattic/harper#634
-   feat: add some words to curated dictionary by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#596
-   feat(web): make underlines animate into existence on page load by [@&#8203;elijah-potter](/~https://github.com/elijah-potter) in Automattic/harper#664
-   Chock full by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#666
-   Several New Linters by [@&#8203;elijah-potter](/~https://github.com/elijah-potter) in Automattic/harper#663
-   feat: multi-word proper nouns for Canada by [@&#8203;hippietrail](/~https://github.com/hippietrail) in Automattic/harper#657
-   fix(core): edge cases in the closed compound noun rule by [@&#8203;elijah-potter](/~https://github.com/elijah-potter) in Automattic/harper#670
-   docs: add nixpkgs as an installation method by [@&#8203;sumnerevans](/~https://github.com/sumnerevans) in Automattic/harper#656

#### New Contributors

-   [@&#8203;sumnerevans](/~https://github.com/sumnerevans) made their first contribution in Automattic/harper#656

**Full Changelog**: Automattic/harper@v0.20.0...v0.21.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](/~https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjkuMyIsInVwZGF0ZWRJblZlciI6IjM5LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working harper-core linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Wrongly flagging common "some ways" and suggesting the rare "someways"
1 participant