Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional CODEOWNERS subteams #1002

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

BrandonPacewic
Copy link
Member

@BrandonPacewic BrandonPacewic commented Jun 28, 2024

Current behaviour for new codeowner file:

  • @HunterBarclay Now auto requested for review on every change.
  • Changes in /exporter/, /fission/src/aps/, /fission/src/mirabuf/, /fission/src/proto/, and /installer/ auto request to @Autodesk/fusion.
  • Changes in fission/src/ui/components/ and fission/**/*.css (all .css files in /fission/ auto request to @PepperLola @LucaHaverty (current "ui" framework people).
  • All other changes that are not for files specified above will reach the fallback pattern of @autodesk/synthesis-devs (@HunterBarclay will still be requested).

This is not final and I would appreciate any and all name suggestions for the teams.

Currently they are:

  • fission currently corresponds to general feature development.
  • fusion currently corresponds to the exporter and other cross platform "integration" things.
  • Currently no UI team, currently specifying @PepperLola and @LucaHaverty as the reviewers on just the reusable UI components.

@BrandonPacewic BrandonPacewic self-assigned this Jun 28, 2024
@BrandonPacewic BrandonPacewic requested a review from a team as a code owner June 28, 2024 02:33
@BrandonPacewic BrandonPacewic requested review from HunterBarclay, Dhruv-0-Arora and PepperLola and removed request for a team and Dhruv-0-Arora June 28, 2024 02:33
@PepperLola
Copy link
Contributor

Is our fusion team blocking anyone else at Autodesk from using that team name, and could that be an issue going forward?

@BrandonPacewic
Copy link
Member Author

Is our fusion team blocking anyone else at Autodesk from using that team name, and could that be an issue going forward?

Well this would only affect the open source Autodesk organization. They won't use this team name internally because they have a internal closed-source organization called fusion already.

@BrandonPacewic BrandonPacewic changed the base branch from dev to master June 28, 2024 22:01
@BrandonPacewic BrandonPacewic changed the base branch from master to dev June 28, 2024 22:01
Copy link
Contributor

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, now for the cool codenames...

@HunterBarclay HunterBarclay self-requested a review July 3, 2024 05:53
@HunterBarclay HunterBarclay merged commit d67cee2 into dev Jul 3, 2024
12 checks passed
@HunterBarclay HunterBarclay deleted the branp/codeowner-subteams branch July 3, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants