mavutil: cope with enum entry rename #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two entries were renamed in the MAV_TYPE enumeration. Since mavutil uses those enumeration entries without checking if they exist, using the entries which no longer exist goes poorly. Rename was done here: /~https://github.com/mavlink/mavlink/pull/1818/files
tridge
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two entries were renamed in the MAV_TYPE enumeration. Since mavutil uses those enumeration entries without checking if they exist, using the entries which no longer exist goes poorly.
Rename was done here: /~https://github.com/mavlink/mavlink/pull/1818/files
Alternative to #889
Tested on the command-line for the values currently in the mavlink commit references in ardupilot/master