309 prepare ship systems for logic + power wires #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.active_blocks.swap_remove(idx); | ||
| } | ||
| } | ||
|
|
||
| /// Returns true if a structure block is within this line |
There was a problem hiding this comment.
Comment should match the type of the parameter.
| } | ||
| } | ||
|
|
||
| fn register_logic_connections_for_laser_cannon(blocks: Res<Registry<Block>>, mut registry: ResMut<Registry<LogicBlock>>) { |
There was a problem hiding this comment.
To keep the logic system uniform, you might move these logic systems to a file in the specific blocks folder, with the logic indicator and the others.
There was a problem hiding this comment.
I'm going to keep the laser_cannon_input_event_listener in the laser_cannon_system file, since I think it's very coupled to laser cannon system logic, but I'll move the register_logic_connections_for_laser_cannon.
| @@ -269,6 +281,49 @@ fn update_missile_system( | |||
| } | |||
| } | |||
|
|
|||
| fn register_logic_connections_for_missile_launcher(blocks: Res<Registry<Block>>, mut registry: ResMut<Registry<LogicBlock>>) { | |||
There was a problem hiding this comment.
Same as laser logic systems.
DanielStebbins
approved these changes
Aug 12, 2024
DanielStebbins
deleted the
309-prepare-ship-systems-for-logic-+-power-wires
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.