Fix oraclelinux minizip build + actually run zip unit tests #1744

sylvlecl · 2023-11-03T14:59:14Z

Description

See #1741: support for zip output is not working on our oracle linux distribution,
because zlib is not installed on the build image.

It should have been identified by zip writer unit test, but it's not run by the workflow, unfortunately.

Quick fixes

Install zlib on oraclelinux build image
Add missing "unit" label to relevant unit tests

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

This reverts commit 02abf46.

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

sonarqubecloud · 2023-11-06T08:56:45Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

flomnes

Reproduced runtime error in OL8 with v8.7.0

I was unable to verify if this patch fixes, since OL8 jobs are only run "rarely".

sylvlecl · 2023-11-07T14:37:00Z

I was unable to verify if this patch fixes, since OL8 jobs are only run "rarely".

I checked the fix once unit tests have been activated, in those workflows:

this one fails, before the fix (before addition of zlib)
this one succeeds, after the fix

* Add unit label to zip writer test Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Enable oracle linux build only Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Fix test property Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Enable oracle linux CI Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Retry oracle CI Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Install zlib on oracle linux build image Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Revert "Enable oracle linux build only" This reverts commit 02abf46. * Revert oracle CI activation Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Add other missing test labels Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Fix test name Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> --------- Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> (cherry picked from commit f6c8f7f)

* 8.8.0-rc1 * Update changelog, version numbers * Fix version numbers * RC++ * [skip ci] Changelog * Fix Oracle Linux minizip build + actually run zip unit tests (#1744) * Add unit label to zip writer test Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Enable oracle linux build only Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Fix test property Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Enable oracle linux CI Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Retry oracle CI Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Install zlib on oracle linux build image Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Revert "Enable oracle linux build only" This reverts commit 02abf46. * Revert oracle CI activation Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Add other missing test labels Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Fix test name Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> --------- Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> (cherry picked from commit f6c8f7f) * RC3 --------- Co-authored-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> Co-authored-by: Jason Marechal <jason.marechal+github@gmail.com>

* 8.8.0-rc1 * Update changelog, version numbers * Fix version numbers * RC++ * [skip ci] Changelog * Fix Oracle Linux minizip build + actually run zip unit tests (#1744) * Add unit label to zip writer test Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Enable oracle linux build only Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Fix test property Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Enable oracle linux CI Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Retry oracle CI Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Install zlib on oracle linux build image Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Revert "Enable oracle linux build only" This reverts commit 02abf46. * Revert oracle CI activation Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Add other missing test labels Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Fix test name Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> --------- Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> (cherry picked from commit f6c8f7f) * RC3 * Take variable status (integer/continuous) into account for MILP * Apply remark --------- Co-authored-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> Co-authored-by: Jason Marechal <jason.marechal+github@gmail.com>

* Add unit label to zip writer test Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Enable oracle linux build only Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Fix test property Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Enable oracle linux CI Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Retry oracle CI Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Install zlib on oracle linux build image Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Revert "Enable oracle linux build only" This reverts commit 02abf46. * Revert oracle CI activation Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Add other missing test labels Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> * Fix test name Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> --------- Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com> (cherry picked from commit f6c8f7f)

sylvlecl added 2 commits November 3, 2023 15:56

Add unit label to zip writer test

9efbfc7

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

Enable oracle linux build only

02abf46

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

pull-request-size bot added the size/XL label Nov 3, 2023

sylvlecl added 4 commits November 3, 2023 16:01

Fix test property

e4027f1

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

Enable oracle linux CI

4be5eba

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

Retry oracle CI

c28d575

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

Install zlib on oracle linux build image

972c2d7

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

sylvlecl changed the title ~~Fix/activate zip unit test~~ Actually run zip unit test Nov 6, 2023

sylvlecl added 3 commits November 6, 2023 08:59

Revert "Enable oracle linux build only"

72ccb64

This reverts commit 02abf46.

Revert oracle CI activation

ab9a27d

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

Add other missing test labels

8fe21ea

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

pull-request-size bot added size/XS and removed size/XL labels Nov 6, 2023

Fix test name

a8379be

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

sylvlecl marked this pull request as ready for review November 6, 2023 08:13

sylvlecl changed the title ~~Actually run zip unit test~~ Fix oraclelinux minizip build + actually run zip unit tests Nov 6, 2023

sylvlecl mentioned this pull request Nov 6, 2023

Cmake helper functions for tests #1748

Closed

sylvlecl requested a review from flomnes November 7, 2023 10:15

flomnes approved these changes Nov 7, 2023

View reviewed changes

flomnes merged commit f6c8f7f into develop Nov 7, 2023

flomnes deleted the fix/activate-zip-unit-test branch November 7, 2023 10:33

watermelon-copilot-for-code-review bot mentioned this pull request Dec 12, 2023

Fix YML for CentOS7 & OL8 #1818

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix oraclelinux minizip build + actually run zip unit tests #1744

Fix oraclelinux minizip build + actually run zip unit tests #1744

sylvlecl commented Nov 3, 2023 •

edited

Loading

sonarqubecloud bot commented Nov 6, 2023

flomnes left a comment

sylvlecl commented Nov 7, 2023

Fix oraclelinux minizip build + actually run zip unit tests #1744

Fix oraclelinux minizip build + actually run zip unit tests #1744

Conversation

sylvlecl commented Nov 3, 2023 • edited Loading

sonarqubecloud bot commented Nov 6, 2023

flomnes left a comment

Choose a reason for hiding this comment

sylvlecl commented Nov 7, 2023

sylvlecl commented Nov 3, 2023 •

edited

Loading