perf: write balance to local storage on beforeunload #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ditches the use of svelte-persisted-store for the
balancestate, so that we writes the wallet balance value to local storage only on Window'sbeforeunloadevent instead of writing on every value change.Motivation
While I'm trying to debug performance issues, I noticed that every
dropBallcall has anupdateStoragecall to update the local storage. While this occupies a small amount of time, my computer has a fast SSD so writing to disk is fast. The same cannot be said for low-end devices where I/O time is slow.