Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable git safe repo check and optimize behavior #10

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

rcdailey
Copy link
Contributor

@rcdailey rcdailey commented Apr 25, 2022

List of changes:

  • Add global config option to make our clone directory "safe". Without
    this, the github action fails completely due to some security features
    implemented in the newest version of git.
  • Consolidated a lot of git operations toward the bottom of the
    entrypoint script to avoid popping in & out of the clone directory
    more than needed.
  • Use clone instead of init + pull for simpler logic and automatic
    origin remote to make later operations simpler.
  • The final git push command has been simplified greatly.

@rcdailey rcdailey force-pushed the fixes branch 3 times, most recently from fcddf05 to 964b1fa Compare April 25, 2022 03:57
List of changes:

- Add global config option to make our clone directory "safe". Without
  this, the github action fails completely due to some security features
  implemented in the newest version of git.
- Consolidated a lot of git operations toward the bottom of the
  entrypoint script to avoid popping in & out of the clone directory
  more than needed.
- Use `clone` instead of `init` + `pull` for simpler logic and automatic
  `origin` remote to make later operations simpler.
- The final `git push` command has been simplified greatly.
@Andrew-Chen-Wang
Copy link
Owner

Thanks a ton for this vital update!

@Andrew-Chen-Wang
Copy link
Owner

Sorry about that! Didn't read it carefully. Thanks for this PR!!!!

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit 194d37f into Andrew-Chen-Wang:master Apr 27, 2022
@rcdailey
Copy link
Contributor Author

Thank you for your time and quick turn around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants