Swift 2.3 support #28
Conversation
|
Hey thanks a lot for that, I'm sorry I've not been very active on Reusable lately and letting you do all the work ^^ The vertical spaces were here on purpose just because I like to give some air to my code by clearly separating those different sections visually. That must be a new rule in more recent SwiftLint versions, as it didn't warn me about that before. But I'm ok getting rid of those extra blank lines as SwiftLint seems to suggest that is part of common convention to avoid them; so let's not modify the SwiftLint configuration and remove those extra lines like you did! |
| @@ -1,5 +1,10 @@ | |||
| # CHANGELOG | |||
|
|
|||
| ## 2.5.1 | |||
|
|
|||
| * Adopted source files and demo project for Swift 2.3 | |||
There was a problem hiding this comment.
Please end this line with a full stop and two spaces (so that the rendered markdown inserts a newline there while still staying in the same paragraph)
|
|
||
| SPEC CHECKSUMS: | ||
| Reusable: 1775ede04719c488bb04e809d923cbb7214168b8 | ||
|
|
||
| PODFILE CHECKSUM: 396891106f5d114bc0d21fe52c4957aa880dd013 | ||
|
|
||
| COCOAPODS: 1.0.1 | ||
| COCOAPODS: 1.1.0.rc.2 |
There was a problem hiding this comment.
CocoaPodd 1.1.0 officially got released today, so that PR is the perfect occasion to use the non-RC version now :)
There was a problem hiding this comment.
Already 1.1.1 ;) Updated in a65e3c0
|
@AliSoftware I think this is completely personal thing about the vertical lines to separate the code chunks and yes, If you agree to leave the rule as a default from |
|
Other than the small nitpickings above, seem 👌 to me! |
|
I totally plan to configure Danger on all my OSS repos some day, still haven't had the time to activate it but was already something I really want to do! 😉 |
|
Ok, only missing thing seems to be the version bump in the podspec now 😉 Btw, funny to see that you end all your commit messages with a semicolon 😄 first time I see this, is that some muscle memory from ObjC? ^^ or some style rule you saw somewhere? Just curious |
|
@AliSoftware haha, I, to be honest, don't have any explanation why. I think that comes from the |
|
@AliSoftware podspec is now ready for the new release 🚀. By the way, I've noticed that there are lots of releases in CHANGELOG contain only one PR, and I found that interesting. Have you ever thought about making a release after each PR, so each PATCH and MINOR feature come to the community as soon as possible? |
| @@ -1,5 +1,10 @@ | |||
| # CHANGELOG | |||
|
|
|||
| ## 2.5.1 | |||
There was a problem hiding this comment.
Don't forget to change the version in the podspec too 😉
|
Cool 👍 Will merge when I have a little time to make that release at home! |
There was a problem hiding this comment.
Just realized that this PR doesn't change travis.yml so Travis only tests this PR against Xcode7
Might be a good idea to borrow the changes made in .travis.yml from the other PR to ensure Travis tests both Xcode 7 (Swift 2.2) and Xcode 8 (Swift 2.3) of this branch
|
@AliSoftware good point, thanks. I've updated in d77c169, also I've changed to install no the beta version of CocoaPods. Does it makes sense to you? |
|
@AliSoftware hey, do you have time to check d77c169? |
As discussed in #20, the decision we came up - is to make a new PATCH release with Swift 2.3 support. This PR contains meta changes for 2.3 support 🚀
Also
Swiftlintreported some vertical space violations. @AliSoftware could you please clarify were the spaces added on purpose?