Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixing up make an offer duplication #1120

Merged
merged 4 commits into from
Jun 10, 2024
Merged

docs: fixing up make an offer duplication #1120

merged 4 commits into from
Jun 10, 2024

Conversation

ansabgillani
Copy link
Contributor

@ansabgillani ansabgillani commented Jun 5, 2024 •
edited
Loading

Fixes: #1114

@ansabgillani ansabgillani marked this pull request as draft June 5, 2024 12:46
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jun 5, 2024 •
edited
Loading

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 877de2b
Status: ✅  Deploy successful!
Preview URL: https://53b64f9d.documentation-7tp.pages.dev
Branch Preview URL: https://awg-fix-the-duplication-for.documentation-7tp.pages.dev

View logs

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

Cloudflare deployment logs are available here

@ansabgillani ansabgillani requested review from dckc, toliaqat and a user June 5, 2024 12:58
@ansabgillani ansabgillani marked this pull request as ready for review June 5, 2024 12:58
Jovonni
Jovonni reviewed Jun 7, 2024
View reviewed changes
main/guides/getting-started/explainer-how-to-make-an-offer.md
![The Trade.tsx component button which calls the makeOffer function](./assets/keplr-legible-offer.png)
### How it Looks
Here is how the UI looks after completion:
![The UI look after completing the UI tutorial](./assets/dapp-offer-up-run.gif)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition of gif

Jovonni
Jovonni approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@Jovonni Jovonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, minor commentary. good additions

@ansabgillani ansabgillani merged commit bb3c8fa into main Jun 10, 2024
5 checks passed
@ansabgillani ansabgillani deleted the awg/fix-the-duplication-for-making-an-offer branch June 10, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc left review comments

@Jovonni Jovonni Jovonni approved these changes

@toliaqat toliaqat Awaiting requested review from toliaqat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 Making an Offer pages - how do they relate?
3 participants
@ansabgillani @dckc @Jovonni