Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow liq margin plus fees for new loans #2813

Merged
merged 3 commits into from
Apr 6, 2021
Merged

fix: allow liq margin plus fees for new loans #2813

merged 3 commits into from
Apr 6, 2021

Conversation

dtribble
Copy link
Member

@dtribble dtribble commented Apr 5, 2021

closes: #2811

  • issue: there is not a test to check that the limit is enforced

@dtribble dtribble requested a review from Chris-Hibbert April 5, 2021 22:53
@dtribble dtribble enabled auto-merge (squash) April 6, 2021 01:26
@dtribble dtribble merged commit 5284548 into master Apr 6, 2021
@dtribble dtribble deleted the 2811_vault_creation_margin branch April 6, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce greater than liquidationMargin before accepting offer to create vault
2 participants
@dtribble @Chris-Hibbert