Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vat storage syscalls to kernel #1856

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Add vat storage syscalls to kernel #1856

merged 1 commit into from
Oct 13, 2020

Conversation

FUDCo
Copy link
Contributor

@FUDCo FUDCo commented Oct 10, 2020

No description provided.

@FUDCo FUDCo added enhancement New feature or request SwingSet package: SwingSet labels Oct 10, 2020
@FUDCo FUDCo requested a review from warner October 10, 2020 00:54
@FUDCo FUDCo self-assigned this Oct 10, 2020
warner
warner approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

packages/SwingSet/src/kernel/kernelSyscall.js
@@ -42,6 +43,28 @@ export function makeKernelSyscallHandler(tools) {
return OKNULL;
}

function vatstoreKeyKey(vatID, key) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KeyKey?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You bet!

@FUDCo FUDCo force-pushed the vat-store-syscall branch from 747296d to 965496d Compare October 13, 2020 17:22
@FUDCo FUDCo merged commit 90ef974 into master Oct 13, 2020
@FUDCo FUDCo deleted the vat-store-syscall branch October 13, 2020 17:32
@warner warner mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warner warner warner approved these changes

Assignees

@FUDCo FUDCo

Labels
enhancement New feature or request SwingSet package: SwingSet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FUDCo @warner