Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send and receive Remotable tags #1628

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Send and receive Remotable tags #1628

merged 1 commit into from
Aug 28, 2020

Conversation

erights
Copy link
Member

@erights erights commented Aug 27, 2020

Attempting progress on the #804 plan.

Tag ERTP brands with allegedName as "interface". Should reappear on remote presence of brand.

As a temporary measure, until we get petname-based rendering in the repl, we currently require all string ifaces to be either 'Remotable' or to start with 'Alleged: ', since the name (e.g., brand name) is only according to the object itself and we have no other way to urge caution in reading too much into these. This is temporary.

Residual TODO #1631

@erights erights requested review from warner and michaelfig August 27, 2020 03:50
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to land when tests pass.

@erights erights changed the title WIP: send and receive Remotable tags Send and receive Remotable tags Aug 28, 2020
@erights erights marked this pull request as ready for review August 28, 2020 00:39
@erights erights merged commit 1bae122 into master Aug 28, 2020
@erights erights deleted the transmit-ifaces branch August 28, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants