First cut at kernel stats collection facility #1131
Conversation
FUDCo
added
enhancement
There was a problem hiding this comment.
That looks great.
The only improvement I can think of is to maybe tolerate upgrade by having loadStats fill in defaults for any that weren't present on disk (rename the initial let kernelStats = { .. } declaration to initialStats, copy it into kernelStats on first run, and then loadStats becomes something like kernelStats = { ...JSON.parse(..), ...initialStats }. I'm not entirely sure it's a good idea, because if we e.g. add a new statistic, sure we don't have to delete the whole save file, but now the resulting stats will be kind of corrupted, because we'll be missing data on the new statistic for whatever happened in the previous run. I'm generally thinking that corrupted/incomplete stats are better than forcing someone to blow away their whole swingset machine due to a stats improvement that they probably don't even care about, but I could be talked out of it.
+1 to land, with or without a stats-upgrade change, your call.
(of course, rebase to current trunk before landing, as usual)
No description provided.