Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a seat in zcf.mintGains if one isn't provided #1696

Closed
Chris-Hibbert opened this issue Sep 4, 2020 · 0 comments · Fixed by #1762
Closed

add a seat in zcf.mintGains if one isn't provided #1696

Chris-Hibbert opened this issue Sep 4, 2020 · 0 comments · Fixed by #1762
Assignees
Labels
bug Something isn't working enhancement New feature or request Zoe package: Zoe

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

zcf.mintGains() allows the seat parameter to be defaulted, but doesn't currently fill it in when missing.

   // TODO unimplemented
   assert(
     zcfSeat !== undefined,
     details`On demand seat creation not yet implemented`,
   );

Description of the Design

use a mechanism like makeEmptySeatKit() (or maybe use makeEmptySeatKit()) to fill in a seat when it's not present

Security Considerations

This doesn't add extra vulnerabilities to Zoe, but it's an extra mechanism in contracts that makes it possible to create a seat and then lose track of it, losing assets.

Test Plan

add a test case in test-zcf.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Zoe package: Zoe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant