Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: config proposal within package.json #36

Merged
merged 1 commit into from
Nov 30, 2023
Merged

refactor: config proposal within package.json #36

merged 1 commit into from
Nov 30, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Nov 30, 2023

I had a thought that each proposal test is a package, so let's put the essential info in the package.json.

Taking this further, the test.sh and eval.sh could be package scripts.

This just moves the config for now.

Tested by rebuilding Dockerfile and seeing that it's exactly the same.

@turadg turadg requested review from dckc and Chris-Hibbert November 30, 2023 22:49
dckc
dckc approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

config.json did seem like an odd wart

@turadg turadg enabled auto-merge November 30, 2023 23:39
@turadg turadg merged commit b28c5ec into main Nov 30, 2023
1 check passed
@turadg turadg deleted the ta/proposal-package branch November 30, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

@Chris-Hibbert Chris-Hibbert Awaiting requested review from Chris-Hibbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turadg @dckc