-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel build: Bump Imath version to current master #949
Conversation
Signed-off-by: Vertexwahn <julian.amann@tum.de>
Is there a way to do this symbolically, that doesn't depend on the explicit hash value? Are we expected to update this after every commit to Imath's master branch? |
TL;DR: I can pin it to the master of Imath instead of bumping - but this has drawbacks Long version: If you do not have a monorepo you have always the dilemma of how to combining different repositories. A focus of Bazel is to have reproducible builds. Therefore, Bazel is not happy about using Option 1 In the case we want always to use the newest and greatest
Nevertheless this would trigger a Bazel warning:
This is only a warning to the user to pin the Imath version. It does not block building or anything else. The user can pin in the
BTW: This works because we use the keyword Advantages:
Disadvantages:
Option 2 Keep it as it is ;) Disadvantages:
Advantages:
Option 3 Extension of Option 1:
Similar to option 1. Which option do you prefer? I can go for Option 1/3 - but this has also some drawbacks |
For the records: When going for Option 1 it would make sense to add in the long run a WORKSPACE and BUILD file to the Imath repo and a corrsponding Bazel build test in the Imath repo. If this is not wished I would stay with the current setting. |
#944 adds a similar CMake mechanism of indicating the version of Imath. Since I don't use Bazel, I don't really have an opinion about the best approach, so I'll defer to you and let you update it as you see fit. Once Imath is officially released and has release tags, presumably it would be best to fix the version to one of those tags. |
OpenEXR should use the current Imath master