Address issues with mingw and win32 wide filenames #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
… util tests Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
…anually creating std::fstreams Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the internals of ImfStdIO.cpp to use wide filenames under win32 so as to handle when compiling with mingw, where older versions do not correctly implement the MSVC extension to take a wide filename in to the filename. This does that, and then adds a similar mechanism to the locations in the various test programs that were creating i/o fstreams.
Further, it fixes issues accessing the temp folder for the IlmImfTest and UtilTest programs under win32, and cleans up files.
The default "make test" now passes when cross compiling for windows using mingw from linux, running under wine.