Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Python wheel workflow, add tests and a CMake setup for bindings #1517

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

cary-ilm
Copy link
Member

  • Remove the libdeflate patch, not actually necessary
  • Add a CMake build setup, controlled OPENEXR_BUILD_PYTHON, off by default
  • Update the doc strings
  • Add #define PY_SSIZE_T_CLEAN, apparently required in Python 3.10 for Py_BuildValue("s#"). PreviewImage attributes crash otherwise.
  • Add a more extensive unit test
  • Disable building PyPy wheels, since the bindings don't work properly (the channels() method fails in test_unittests.py when built against PyPy)

… bindings

- Remove the libdeflate patch, not actually necessary
- Add a CMake build setup, controlled ``OPENEXR_BUILD_PYTHON``, off by default
- Update the doc strings
- Add ``#define PY_SSIZE_T_CLEAN``, apparently required in Python 3.10
  for ``Py_BuildValue("s#")``. PreviewImage attributes crash
  otherwise.
- Add a more extensive unit test
- Disable building PyPy wheels, since the bindings don't work properly
  (the ``channels()`` method fails in ``test_unittests.py`` when built
  against PyPy)

Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm
Copy link
Member Author

I'm going to merge this as is, we can deal with any issues later. It still needs work, as the bindings crash on various inputs, which doesn't appear to be a new problem.

@cary-ilm cary-ilm merged commit 318536c into AcademySoftwareFoundation:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant