Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python wheels #1487

Merged
merged 30 commits into from
Jul 28, 2023
Merged

Python wheels #1487

merged 30 commits into from
Jul 28, 2023

Conversation

sanguinariojoe
Copy link
Contributor

@sanguinariojoe sanguinariojoe commented Jul 14, 2023

This is just a nutshell, to be improved in the future...

I am on the process of integrating this here, as discussed on sanguinariojoe/pip-openexr#11.

The first step, which is just producing the python wheels automagically in this very same repo, is done (look /~https://github.com/sanguinariojoe/openexr/actions/runs/5552026141 (Still running)). Along this line, I already submitted an issue to libdeflate guys to fix a problem which will render the patch needless.

The wheels are uploaded as an artifact, and then they should be manually uploaded to pypi. So probably the next step (after merging this) will be giving you access to the pypi repo. To this end, one of the core developers shall write me a message, so I can give him a simple challenge. Something like uploading a text file on a specific branch.

Then we can think on auto-uploading the Python wheels, which would require to define a protocol. Indeed, versions cannot be overwritten on pypi, so as it is configured right now every single commit on main requires a change on the version. But maybe you prefer to create a stable branch, and build the Python wheels just there... To be figured out

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 14, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@sanguinariojoe
Copy link
Contributor Author

Apparently a test failed, but I do not think it is related to my changes. Please, confirm

@cary-ilm
Copy link
Member

Thank you for this contribution! We will be happy to accept it. Our bandwidth for this is a bit limited at the moment as we prepare for an upcoming release, but we are definitely interested in integrating the python bindings into official OpenEXR project.

The test failure was indeed spurious, as you suggested, I reran the failed tests and they succeeded.

Would you be willing to consider providing this contribution under the BSD-3-Clause license? That's the standard license used by the project, and it simplifies things to limit the divergence from that. Also, could you append a copyright/license identifier clause as a header in each file? Our standard is:

# SPDX-License-Identifier: BSD-3-Clause
# Copyright (c) Contributors to the OpenEXR Project.

We will need some time to discuss this internally, but we're definitely eager in working out the details.

Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
@sanguinariojoe
Copy link
Contributor Author

Our bandwidth for this is a bit limited at the moment as we prepare for an upcoming release, but we are definitely interested in integrating the python bindings into official OpenEXR project.

No prob, take your time. As I told you this is just a nutshell, so a whole line of working will be arising from this PR.

Would you be willing to consider providing this contribution under the BSD-3-Clause license? That's the standard license used by the project, and it simplifies things to limit the divergence from that. Also, could you append a copyright/license identifier clause as a header in each file?

Sure thing! I did that on 670bd05

@cary-ilm
Copy link
Member

Thanks for the contribution. We're preparing for a 3.2 release in mid-August, but we'll follow up after that regarding the process of uploading to pypi.

I think this build workflow can be simplified a bit, I'll follow up separately about that.

Regarding the POSITION_INDEPENDENT_CODE patch for libdeflate, I see the ebiggers/libdeflate#317 issue is still open. I haven't experimented with it yet, but do you see any reason the suggested CMake option won't suffice?

@cary-ilm cary-ilm merged commit af87558 into AcademySoftwareFoundation:main Jul 28, 2023
@sanguinariojoe
Copy link
Contributor Author

The option is just perfectly fine. The notification just went under my radar...

Would you please add that option and remove the patch yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants