Remove some DeprecationWarnings #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se an exception in future versions. Signed-off-by: Evan Blaudy <evan@cg-wire.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1688 +/- ##
=======================================
Coverage 79.84% 79.84%
=======================================
Files 197 197
Lines 21792 21792
Branches 4358 4358
=======================================
Hits 17399 17399
Misses 2232 2232
Partials 2161 2161
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
|
From meeting discussion: we plan to land this and then copy it over into the new FCP XML adapter repo. |
darbyjohnston
pushed a commit
to darbyjohnston/OpenTimelineIO
that referenced
this pull request
Jun 14, 2024
…se an exception in future versions. (AcademySoftwareFoundation#1688) Signed-off-by: Evan Blaudy <evan@cg-wire.com> Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
During the tests some DeprecationWarnings pop up. I only fix them.
Reference associated tests.
For example here you see the DeprecationWarnings : /~https://github.com/AcademySoftwareFoundation/OpenTimelineIO/actions/runs/7483248301/job/20368203066?pr=1669#step:9:18