-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ContractEntry construction #26
Conversation
Deploying with Cloudflare Pages
|
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 24.09% 24.10%
=======================================
Files 266 266
Lines 23369 23375 +6
=======================================
+ Hits 5631 5634 +3
- Misses 17738 17741 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
@adairrr wdyt, do we need to remove TryFrom for UncheckedEntry? |
And if yes, how we can do it harmless |
Is there a reason to? |
Sorry, meant to say remove TryFrom<String<(got trolled by markdown) in favor of TryFrom<&str> because references are always preferable, and we don't benefit from owning a string anyway. In addition can save few bytes in wasms |
Shouldn't we keep the From implementation ? |
Is there's a reason to support both string and string slice? |
Not really no |
module tests failing, will check after merging this. |
This PR implements FromStr for ContractEntry.
Checklist