Add support for predicting opponent orders #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyCharm noticed this for me.
I discovered that the function can return `None` in some cases, so the return type should be `Optional`.
These defaults should be declared in exactly one place.
`diplomacy` has a `SuggestionType` enum, so we should use it in all places instead of explicit integer values. This commit replaces usages in both `int`s and `str`s. I made multiple related changes in this commit: - Factor out description of suggestion types so it is not duplicated throughout the codebase - Remove the `--chiron_type` argument, which is unused - Treat advice level as a bit field so we don't need to enumerate all values that include a particular suggestion type
As I was looking through the logs to help with other changes, I noticed some ways to improve the log output: - Log arguments that were not being logged - Reword unclear and incorrect messages - Fix typos - Remove duplicate log message
Unlike other advisors, CICERO can change what advice it sends each turn. The new checks in `BaselineBot` caught that we do not adjust the field's value when we change what suggestions we send, which means that users might not see the UI elements that we want them to.
These predictions were already being generated, but they were being ignored. We now can enable sending them as advice. We currently intend to use this suggestion type only in Llama advisor. There is no plan to display it in the UI.
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation for a new suggestion type that predicts the orders of opponents. I made some related improvements to the advisor, most of them being related to the suggestion code.
For the library and UI implementations, see ALLAN-DIP/diplomacy#34. For client support, see ALLAN-DIP/chiron-utils#20.