Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invitation email formatting #1067

Merged
merged 6 commits into from
May 2, 2024
Merged

Conversation

Pursottam6003
Copy link
Collaborator

Description

Dear Reviewer

Earlier there was some issue in the invite code link as the URL was hardcoded.
Since we have two environments development and production so it was a minor task to update the URL dynamic
image (2)

Secondly, I found there was no styling in the invitation email so I thought to add some styling in the function and refactored the code

Fixes # (issue)

Type of change

Minor type of change
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests / checks that you performed to verify your changes. Provide instructions so we can reproduce. Please delete options that are not relevant.

  • Tested the API endpoint on Swagger with the 'Try it out' feature
  • Tested the Models using the Django Shell
  • Any other tests you performed for checking edge cases.
  • Any other tests you performed for checking exceptions.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Checklist for Models

If you added new models / made changes to exsting models, please fill this checklist.

  • The primary key of the Model is an AutoField
  • I have defined the __str__ method for the Model
  • If the field is optional, it has been spcified explicitly
  • I have added a verbose_name for each Field.
  • I have added a docstring for the Model
  • The model is registered on Admin Site.
  • I have pushed the migrations.

Checklist for API

If you added new api endpoints / made changes to exsting endpoints, please fill this checklist.

  • The endpoint is accessible through Swagger.
  • The endpoint supports permissions and authentication for different roles.
  • All exceptions have been handled and appropriate status code is returned to the user.
  • I have added docstrings for ViewSets / Serializers.

@ishvindersethi22 ishvindersethi22 merged commit 3b8cbc6 into dev May 2, 2024
1 check passed
@ishvindersethi22 ishvindersethi22 deleted the invitation_email_formatting branch May 2, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants