Cleanup orchestrator proto #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JoeZijunZhou
commented
Jul 15, 2024
JoeZijunZhou
commented
- Removed unused fields in orchestrator proto
- Update all files according to the proto cleanup
FanhaiLu1
reviewed
Jul 16, 2024
| @@ -26,9 +26,6 @@ service Orchestrator { | |||
| } | |||
|
|
|||
| message DecodeRequest { | |||
| // Where to load any pre-existing kv cache from. | |||
| string session_cache = 1; | |||
There was a problem hiding this comment.
In future, we will have prefill cache logic. Is this filed related with prefill cache?
There was a problem hiding this comment.
This is for history cache originally. We could add prefill cache fields when we implement it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.