Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase scan reliability #3262

Merged
merged 1 commit into from
Aug 3, 2016
Merged

Increase scan reliability #3262

merged 1 commit into from
Aug 3, 2016

Conversation

chuyskywalker
Copy link
Contributor

  • Handle exceptions better
  • Prevent search_workers from even fully exiting
  • High-load sleep timer is now backoff based instead of a randomly assigned absolute value
  • Logins will retry login-retries times before throwing an exception to the search_worker thus creating a new PgoAPI instance and starting over

 - Handle exceptions better
 - Prevent search_workers from even fully exiting
 - High-load backoff is now backoff based instead of randomly assigned absolute
 - Logins will retry `login-retries` times before throwing an exception to
   cause the search_worker to create a new PgoAPI instance and start over
@DomGrieco
Copy link

What's the purpose of the login-retries? Setting it to a lower number would mean less chance of looking suspicious?

@chuyskywalker
Copy link
Contributor Author

Essentially, I've had instances where the PgoAPI api.login calls got "stuck". It would half login, fail, and never actually get logged back in. Because it's a single call, it would do this forever. Placing a limit on this allows the search_worker thread to bail out and start over -- creating a new api instance solves the problem*.

* I "turn it off and on again" essentially

@eluz1ve
Copy link

eluz1ve commented Aug 3, 2016

You want to say that I don't see message about 15minutes ban anymore? ^_^

@invisiblek invisiblek merged commit 59cead7 into AHAAAAAAA:pgoapi-purge Aug 3, 2016
@chuyskywalker chuyskywalker deleted the safer-threads branch August 3, 2016 13:27
invisiblek added a commit that referenced this pull request Aug 3, 2016
* Remove unused scannedLabel() function

* Remove pogom/pgoapi if empty at startup

* use pgoapi from requirements.txt instead of copying its files

* gitignore src/

* Fixups for using mainline pgoapi

* Update pgoapi to latest HEAD

* Use get_pos_by_name from pgoapi

* Update search api for new pgoapi

* Removing cell ID's, this functionality is provided in pgoapi

* Update search for the new pgoapi (again)

* making sure we change with step location, rather than starting position

* silenced logging

* Increase scan reliability (#3262)

- Handle exceptions better
 - Prevent search_workers from even fully exiting
 - High-load backoff is now backoff based instead of randomly assigned absolute
 - Logins will retry `login-retries` times before throwing an exception to
   cause the search_worker to create a new PgoAPI instance and start over

* Update pgoapi

* Show a big scary warning if user hasn't updated

* Use standard logging for this and for the check of the old pogom/pgoapi
* Automatically remove pogom/pgoapi, regardless if its empty or not.
  Its not going to be useful anymore and will cause problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants