Add detailed message to remote failures #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A FailureMessage should include more detailed input to improve feedback to the user. A `distillPaymentFailures` static method is also added to clarify the list of failures associated to a PaymentFailure.
Payments make multiple attempts and the payment failure feedback should reflect that.
pm47
force-pushed
the
failure-messages
branch
from
43e4a44 to
5d4b0cd
Compare
pm47
force-pushed
the
failure-messages
branch
from
5d4b0cd to
8978f69
Compare
pm47
approved these changes
Feb 27, 2018
This was referenced Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A FailureMessage should include detailed information to improve feedback to the user. This should help the user understand the reason why a payment failed.
A
distillPaymentFailuresstatic method is also added to drop theRouteNotFounderror from the list of failures if this failure is not significant.