Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move protocol codecs to their own package #1736

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Move protocol codecs to their own package #1736

merged 4 commits into from
Mar 23, 2021

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Mar 22, 2021

This is a follow-up for #1732

The codecs in the protocol package will always be backwards-compatible, as they are defined in the spec.

@t-bast t-bast requested a review from pm47 March 22, 2021 17:04
pm47
pm47 approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We could also have renamed the parent package to fr.acinq.eclair.types as internal codecs do not go on the wire. But types is a bit generic. Well...

@t-bast t-bast merged commit 7819fae into master Mar 23, 2021
@t-bast t-bast deleted the move-protocol-codecs branch March 23, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm47 pm47 pm47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bast @pm47