Reject unreasonable remote dust limit #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes no sense to use a dust limit that's much higher than what bitcoin mandates, so we should not allow our peer to use invalid values.
t-bast
commented
Feb 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #1694 +/- ##
==========================================
- Coverage 86.04% 86.03% -0.02%
==========================================
Files 151 151
Lines 11491 11494 +3
Branches 497 499 +2
==========================================
+ Hits 9888 9889 +1
- Misses 1603 1605 +2
|
pm47
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes no sense to use a dust limit that's much higher than what bitcoin mandates, so we should not allow our peer to use invalid values.