Remove support for initial_routing_sync #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 85.95% 85.99% +0.04%
==========================================
Files 151 151
Lines 11457 11455 -2
Branches 484 500 +16
==========================================
+ Hits 9848 9851 +3
+ Misses 1609 1604 -5
|
We keep the GetRoutingState API available in the router as it's useful to query network information locally (or between actors), but we stop sending that data to remote nodes.
t-bast
force-pushed
the
remove-initial-routing-sync
branch
from
5d96056 to
02bfe3f
Compare
pm47
approved these changes
Feb 4, 2021
pm47
changed the title
|
Cool, we don't actively use it on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep the
GetRoutingStateAPI available in the router as it's useful to query network information locally (or between actors), but we stop sending that data to remote nodes.I've checked the last week on our node, and there were no queries using initial_routing_sync, so it feels ok to drop support.