Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop support for legacy Python 2 #257

Merged
merged 5 commits into from
May 23, 2019
Merged

chore: Drop support for legacy Python 2 #257

merged 5 commits into from
May 23, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented May 22, 2019

Fixes #255.

@hugovk hugovk mentioned this pull request May 22, 2019
Closed
sloria
sloria reviewed May 22, 2019
View reviewed changes
.travis.yml Outdated
@@ -30,7 +28,3 @@ script:

after_success:
- codecov

branches:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed so I could test my feature branch on Travis CI and be sure it was already passing, I didn't want to submit a broken PR to you!

I can put it restore it if you prefer, although I would recommend leaving it in so others (and you!) can also test their feature branches too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind WIP PRs, actually. I added this specifically so I wouldn't see two Travis builds on my own PR branches.

sloria
sloria reviewed May 22, 2019
View reviewed changes
Copy link
Member

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good on first glance.

We'll probably want to enforce keyword-only arguments in a number of places, but that can happen outside this PR. Other than the .travis.yml change, I don't see any blockers to merging this.

@sloria sloria requested a review from taion May 22, 2019 15:07
taion
taion approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Could you add back the branch filter on the .travis.yml? Then this should be good to go.

tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
hugovk and others added 4 commits May 23, 2019 11:38
@hugovk
Upgrade Python syntax with pyupgrade --py3-plus
9901b7d
@hugovk
The future is now
2460a9f
@hugovk @taion
Test marshmallow2 and 3
79a1831 
Co-Authored-By: Jimmy Jia <tesrin@gmail.com>
@hugovk @taion
Remove duplicate envs
fd8a898 
Co-Authored-By: Jimmy Jia <tesrin@gmail.com>
@hugovk
Copy link
Contributor Author

hugovk commented May 23, 2019

Updated!

@taion
Copy link
Contributor

taion commented May 23, 2019

Thanks so much!

@taion taion changed the title Drop support for legacy Python 2 chore: Drop support for legacy Python 2 May 23, 2019
@taion taion merged commit fc0fed0 into 4Catalyzer:master May 23, 2019
@hugovk hugovk deleted the rm-2 branch May 23, 2019 12:50
@hugovk
Copy link
Contributor Author

hugovk commented May 23, 2019

You're welcome! Onwards with Python 3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloria sloria sloria left review comments

@taion taion taion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Python 2 support
3 participants
@hugovk @taion @sloria