Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove apispec support #250

Merged
merged 2 commits into from
May 23, 2019
Merged

refactor: Remove apispec support #250

merged 2 commits into from
May 23, 2019

Conversation

taion
Copy link
Contributor

@taion taion commented Apr 9, 2019

BREAKING CHANGE: Removes apispec support

This no longer works with the current apispec release, and we don't use it anyway.

BREAKING CHANGE: Removes apispec support
@taion taion requested review from sloria and itajaja April 9, 2019 19:04
@taion
Copy link
Contributor Author

taion commented Apr 9, 2019

cc @cancan101

@@ -171,12 +163,3 @@ def ping():
class FlaskRestyState(object):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could remove this entirely and make the registered extension just be the Api object, but this is probably more future-proof

Copy link
Member

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since all the schemas and stuff live on the view classes, introspection should be straightforward, so there's nothing stopping someone from developing OpenAPI spec generation outside of this library.

@taion taion merged commit 80e5234 into master May 23, 2019
@taion taion deleted the drop-apispec branch May 23, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants