Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Always return response data from assert_response #242

Merged
merged 2 commits into from
Mar 15, 2019
Merged

fix: Always return response data from assert_response #242

merged 2 commits into from
Mar 15, 2019

Conversation

taion
Copy link
Contributor

@taion taion commented Mar 12, 2019

No description provided.

@taion taion closed this Mar 12, 2019
@taion taion deleted the assert_response-returns-data branch March 12, 2019 20:57
@taion taion mentioned this pull request Mar 15, 2019
Merged
@taion taion restored the assert_response-returns-data branch March 15, 2019 17:14
@taion taion reopened this Mar 15, 2019
@cancan101
Copy link
Contributor

perhaps return None in the case of 204 ?

@taion
Copy link
Contributor Author

taion commented Mar 15, 2019

I'm thinking UNDEFINED rather than None, perhaps.

@taion
Copy link
Contributor Author

taion commented Mar 15, 2019

cc @yodaiken @itajaja what do we think?

@itajaja
Copy link
Member

itajaja commented Mar 15, 2019

this makes sense. I think for 204 you shouldn't do anything special, but any other solution is fine

@taion
Copy link
Contributor Author

taion commented Mar 15, 2019

to be clear, you mean the current impl of returning UNDEFINED when the response data are empty?

@itajaja
Copy link
Member

itajaja commented Mar 15, 2019

correct, I mean, you shouldn't check 204 specifically

@taion taion merged commit 7ad1dfa into master Mar 15, 2019
@taion taion deleted the assert_response-returns-data branch March 15, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taion @cancan101 @itajaja