Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow disabling appending slash #165

Merged
merged 2 commits into from
May 23, 2019
Merged

feat: Allow disabling appending slash #165

merged 2 commits into from
May 23, 2019

Conversation

taion
Copy link
Contributor

@taion taion commented Jan 31, 2018

@taion taion requested a review from yodaiken January 31, 2018 22:51
@taion
Copy link
Contributor Author

taion commented Feb 2, 2018

Starting to think this is the wrong approach. Makes more sense to just use StrictRule as rule_class in app. There's no benefit in putting this on Api.

@taion taion changed the title Allow disabling appending slash feat: Allow disabling appending slash May 23, 2019
@taion taion merged commit ab54e54 into master May 23, 2019
@taion taion deleted the slash branch May 23, 2019 19:20
@taion
Copy link
Contributor Author

taion commented May 23, 2019

d'oh, wait, i didn't read my own darn comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itajaja itajaja itajaja approved these changes

@yodaiken yodaiken yodaiken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taion @yodaiken @itajaja