-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements list manipulation functions #945
Conversation
@kjmatsuda, I just wanted to start by thanking you for your amazing PR!🙏 Your new functionality is truly fantastic, and as someone who uses a lot of lists, I know I'll be making great use of it. I took the time to thoroughly test your changes, and I'm happy to report that both the UX and code are very well done. You did an excellent job integrating a non-trivial feature while still maintaining the current UX pattern, and I appreciate the effort you put into refactoring the code where necessary.💯🚀 To improve the user experience even further, I added tooltips and updated the inline docs with your functionality. Your PR includes loads of great features, and as is my usual practice, I wrote an integration test against "creating a new list item of the same type in the middle of an existing list". I've also added your PR to the changelog with attribution, so everyone can see the great work you've done. Finally, I want to apologize for the delay in reviewing and merging your PR. It's quite bizarre, but two weeks ago, just after I reviewed your PR at 6:15pm, someone broke into my home and attacked me. I ended up in the ICU with bruised ribs, a concussion, hematoma, etc. Unfortunately, I wish I could say I was making this up, but it's the truth. So I'm sorry for any inconvenience this may have caused, and I'm grateful for your patience. Again, thank you so much for your contribution. Your hard work and dedication are truly appreciated! |
@munen , thank you for your kind words! It is a great pleasure for me to contribute to organice. I will continue to do so in the future. And I'm sorry for your injury. I hope you will recover soon.🙏 |
Looking forward to it^^
Thank you very much:pray: I'll give my best! |
Hello @munen and @kjmatsuda! Firstly I'm very sorry to hear about your trauma and wish you a speedy recovery. What follows will correctly appear very trivial in contrast. But what is good software development but a series of trivia that add up to something great? This seems like a really nice feature for editing lists. However I'm noticing some awkward regressions in my usage of checkbox lists. Use case: Problems:
Solutions? I didn't want to open an issue without discussing it further. Let me know what you think. |
Hi!
This is a pull request for #400 and #295. I have implemented list manipulation functions as shown below:
Here's a demo of the implementation:
20230320-list-manipulation.mp4
What are your thoughts on this?