fix: UX regression for iOS on Search and TODO List #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, the 'fix' is to disable auto-focus for iOS.
Rationale:
On iOS, setting autoFocus in the `Modal` will move the contents
of the drawer off the screen, because the keyboard pops up late
when the height is already set to '92%' in the `Drawer`. With
Redux, we could certainly propagate a height back, but that seems
hacky and there's other complications:
- There's no API to check if the keyboard is open or not. When
- setting the height of the container to something like 48% for
- iOS, this works on iPhone (tested on Xs and 6S), but when the
- keyboard is closed, the container is still small when the user
- wants to read the longer list without the keyboard in the way.
There might be a better way: If the drawer wouldn't move, iOS
likely would set the heights correctly automatically.
I didn't spend more time on this (it's already hours), because
the _right_ solution would likely be to work on redoing the
design in a well known fashion like Material Design.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #454.
Unfortunately, the 'fix' is to disable auto-focus for iOS. Rationale:
On iOS, setting autoFocus in the
Modalwill move the contents of thedrawer off the screen, because the keyboard pops up late when the
height is already set to '92%' in the
Drawer. With Redux, we couldcertainly propagate a height back, but that seems hacky and there's
other complications:
There might be a better way: If the drawer wouldn't move, iOS likely
would set the heights correctly automatically.
I didn't spend more time on this (it's already hours), because the
right solution would likely be to work on redoing the design in a
well known fashion like Material Design.