Allow capture templates to insert at beginning or end of file #324
Conversation
aspiers
force-pushed
the
capture-bof-eof
branch
2 times, most recently
from
00a999a to
aaf564e
Compare
|
Added tests and rebased on my |
|
@munen I can't figure out why this undoable test is failing - any ideas? |
Wow, you're asking about a failing test in a 42 changes PR that I haven't looked at, yet, because it's marked as a draft. No, at this point, I also don't know why the test is failing, but it looks to be the last commit(; Yeah, I know, that's not helping at all. Sorry about that. What about splitting the PR into two - one that you've manually verified and tested and that we can review. And another one adding more tests on top of and see what's going on? This particular PR seems to have a lot of changes that are not directly related to the title of it. |
aspiers
force-pushed
the
capture-bof-eof
branch
4 times, most recently
from
222a8cd to
22a693b
Compare
|
@munen commented on June 9, 2020 7:39 PM:
Already discussed on Matrix, but just for the record in case anyone else is reading here:
As mentioned, the vast majority of these changes are because it's based on (an old version of) my
No need - the
Yep, as explained above, I wanted to be able to use Unfortunately after a lot more experiments, I still have zero clue why the final undo test is failing. As agreed on Matrix, we'll just skip that test for now :-/ |
This will allow us to check individual headers in some upcoming tests.
A tighter scope will allow us to write more tests with different stores.
Make it clearer what is the second argument passed to the org reducer.
|
Now rebased and ready for review. |
If no headers are in the header path list, insert at the end of the file, or the beginning if the Prepend option is set.
| expect(last.get('rawDescription')).toEqual('Some description\n'); | ||
| }); | ||
|
|
||
| it.skip('is undoable', () => { |
There was a problem hiding this comment.
I don't understand why, yet, but the problem seems to be a racing condition or mutable state somewhere. When only executing this test, it works fine.
|
Cool new feature, indeed! I've added some docs to sample.org, documented the skipped test (and allowed it in eslint) and added attribution in the changelog. Good work, @aspiers 🙏 |
Currently based on #344 (eslint PR) so that I can use eslint to verify the changes are clean.Now rebasedIf no headers are in the header path list, insert at the end of the file, or the beginning if the Prepend option is set.
Lightly tested.