Bugfix: PWA #135
Merged
Bugfix: PWA #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've reverted changes in the display mode. |
|
Thank you for your changes and apolozigize for the long wait. I have the flu and spend most of the time in bed atm. Before merging, I wanted to research what the impact of "display mode" is. But since you reverted that, the merge is of course trivial and 100% good to go! Thank you for the contribution and taking are of the Android ecosystem 🙏 |
|
I updated the changelog with the relevant fix and attribution to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #134. It adds missing icons for app to be installable as PWA.
I've also changed display fromstandalonetofullscreen, which removes any additional UI elements and gives maximum space on the screen for the application. I guess that this is what everybody wants! :)