Added Preparex to the DB statements #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
begmaroman
requested review from
rachit77
and removed request for
Stefan-Ethernal
| @@ -142,12 +180,13 @@ func (db *pgDB) StoreUnresolvedBatchKeys(ctx context.Context, bks []types.BatchK | |||
| return err | |||
| } | |||
|
|
|||
| stmt, err := tx.PreparexContext(ctx, storeUnresolvedBatchesSQL) | |||
There was a problem hiding this comment.
Just curious. We can not prepare statements in the constructor for sql queries that store data? Just the ones that retrieve data?
I am asking this because I see you are not preparing statements for some queries.
There was a problem hiding this comment.
It is executed within the transaction so preparing it in the contractor is not doable. I'll change this logic in the next PR and all queries will be prepared in the constructor.
goran-ethernal
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.