Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it run on root filesystem #397

Closed
dotysan opened this issue Dec 16, 2024 · 1 comment · Fixed by #398
Closed

make it run on root filesystem #397

dotysan opened this issue Dec 16, 2024 · 1 comment · Fixed by #398

Comments

@dotysan
Copy link
Contributor

dotysan commented Dec 16, 2024

The whole logic about not running on NVMe is buggy. It appears to assume the script is in /volume*/ which isn't always true.

We need to be able to run this script in /root or another non-NVMe volume without errors.
dotysan added a commit to dotysan/Synology_HDD_db that referenced this issue Dec 16, 2024
@dotysan
De-spaghettifi shell code
8e7f56b 
 - reduce excesive subshells/piplines
 - improve readability
 - speed up performance
 - fixes 007revad#397
@dotysan dotysan mentioned this issue Dec 16, 2024
Merged
@007revad
Copy link
Owner

I'm surprised nobody else has mentioned this issue as it's existed since January, in v3.4.77

@007revad 007revad mentioned this issue Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

De-spaghettifi shell code dotysan/Synology_HDD_db
2 participants
@dotysan @007revad