Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed zpa_policy_access_rule and semver issues #513

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Jan 8, 2025

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

@willguibr willguibr temporarily deployed to ZPA_PROD_TENANT01 January 8, 2025 16:27 — with GitHub Actions Inactive
@willguibr willguibr temporarily deployed to ZPA_BETA_TENANT01 January 8, 2025 16:27 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (dd82f94) to head (bb09b96).

Files with missing lines Patch % Lines
zpa/common.go 54.54% 7 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   68.70%   70.97%   +2.27%     
==========================================
  Files          92       92              
  Lines       19213    19235      +22     
==========================================
+ Hits        13200    13652     +452     
+ Misses       5220     4728     -492     
- Partials      793      855      +62     
Files with missing lines Coverage Δ
zpa/resource_zpa_policy_access_rule.go 73.04% <100.00%> (ø)
zpa/common.go 60.32% <54.54%> (-0.11%) ⬇️

... and 7 files with indirect coverage changes

@willguibr willguibr merged commit 7cd9192 into master Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
Status: 🚀 Shipped
2 participants