Don't update memory viewer contents while data inspector is editing

Fixes bug where the data inspector text file discards editing mode soon after entering it.
zorgiepoo · Aug 18, 2024 · e6ae84e · e6ae84e
1 parent e6ae97e
commit e6ae84e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/Bit Slicer/ZGMemoryViewerController.m b/Bit Slicer/ZGMemoryViewerController.m
@@ -613,7 +613,7 @@ - (void)hexTextView:(HFTextView *)__unused representer didChangeProperties:(HFCo
 
 - (void)updateDisplayTimer:(NSTimer *)__unused timer
 {
-	if (_currentMemorySize > 0)
+	if (_currentMemorySize > 0 && !_dataInspectorRepresenter.zg_editing)
 	{
 		HFFPRange displayedLineRange = _textView.controller.displayedLineRange;
 

diff --git a/deps/HexFiend/DataInspectorRepresenter.h b/deps/HexFiend/DataInspectorRepresenter.h
@@ -19,6 +19,9 @@ extern NSString * const DataInspectorDidDeleteAllRows;
 
 - (NSUInteger)rowCount;
 
+// Bit Slicer addition: is the data inspector being edited?
+@property (nonatomic, readonly) BOOL zg_editing;
+
 - (IBAction)addRow:(id)sender;
 - (IBAction)removeRow:(id)sender;
 - (IBAction)doubleClickedTable:(id)sender;

diff --git a/deps/HexFiend/DataInspectorRepresenter.m b/deps/HexFiend/DataInspectorRepresenter.m
@@ -316,6 +316,11 @@ - (IBAction)doubleClickedTable:(id)sender {
     }
 }
 
+- (BOOL)zg_editing
+{
+	return table.editedRow != -1;
+}
+
 - (BOOL)control:(NSControl *)control textShouldEndEditing:(NSText *)fieldEditor {
     USE(control);
     NSInteger row = [table editedRow];