Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonoff Trvzb: expose new attributes of firmware 1.3 #3909

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

danielkleinert
Copy link

Proposed change

This change exposes new attributes of the current firmware.

Values are adopted from zigbee-herdsman:
Koenkk/zigbee-herdsman-converters#8837
Koenkk/zigbee-herdsman-converters#8873

I am unsure about the naming. Hysteresis could be better than "Temperature control accuracy".

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@danielkleinert danielkleinert changed the title Sonoff Trzvb: expose new attributes of firmware 1.3 Sonoff Trvzb: expose new attributes of firmware 1.3 Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (b87ac89) to head (4cd260f).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3909   +/-   ##
=======================================
  Coverage   91.00%   91.01%           
=======================================
  Files         328      328           
  Lines       10656    10659    +3     
=======================================
+ Hits         9698     9701    +3     
  Misses        958      958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@photomoose
Copy link

@danielkleinert I’m still waiting for confirmation from Sonoff, but I'm starting to think the "external temperature sensor" attribute is a bit field rather than a simple on/off. See my comment here: Koenkk/zigbee-herdsman-converters#8873 (comment)

@danielkleinert
Copy link
Author

@photomoose Thanks for letting me know. I'll try to map that once you get the confirmation on the semantics.

@panther7
Copy link

issues #3906, #3907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants