Add Tuya mmWave radar 5.8GHz, ZY_HPS01 _TZE204_ex3rcdha
#3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3887 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 328 328
Lines 10651 10652 +1
=======================================
+ Hits 9693 9694 +1
Misses 958 958 ☔ View full report in Codecov by Sentry. |
prairiesnpr
force-pushed
the
add-TZE204_ex3rcdha
branch
from
a5e223c to
f0d495d
Compare
Comment on lines
+1362
to
+1383
| .tuya_number( | ||
| dp_id=111, | ||
| attribute_name="breath_detection_min", | ||
| type=t.uint16_t, | ||
| min_value=0, | ||
| max_value=600, | ||
| step=10, | ||
| unit=UnitOfLength.CENTIMETERS, | ||
| translation_key="breath_detection_min", | ||
| fallback_name="Breath detection min", | ||
| ) | ||
| .tuya_number( | ||
| dp_id=112, | ||
| attribute_name="breath_detection_max", | ||
| type=t.uint16_t, | ||
| min_value=0, | ||
| max_value=600, | ||
| step=10, | ||
| unit=UnitOfLength.CENTIMETERS, | ||
| translation_key="breath_detection_max", | ||
| fallback_name="Breath detection max", | ||
| ) |
There was a problem hiding this comment.
So, these don't have the "distance" device class, but still centimeters as the unit. Is that correct?
There was a problem hiding this comment.
Seems to be missing for others as well. We should add all of these in another PR.
# Conflicts: # tests/test_tuya_motion.py # zhaquirks/tuya/tuya_motion.py
TheJulianJES
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds Tuya mmWave radar 5.8GHz, ZY_HPS01
_TZE204_ex3rcdhaBased on: /~https://github.com/Koenkk/zigbee-herdsman-converters/blob/6c3d7e2aa1fba6f6342baea21e5b3bbd3688cb0e/src/devices/tuya.ts#L13228
Additional information
Closes: #3309
Checklist
pre-commitchecks pass / the code has been formatted using Black