fix: should not ignore slowThreshold (#4655)

zeromicro · Feb 14, 2025 · 790302b · 790302b
1 parent 6a0672b
commit 790302b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/zrpc/internal/serverinterceptors/statinterceptor.go b/zrpc/internal/serverinterceptors/statinterceptor.go
@@ -25,7 +25,7 @@ var (
 
 // StatConf defines the static configuration for stat interceptor.
 type StatConf struct {
-	SlowThreshold        time.Duration `json:",optional"`
+	SlowThreshold        time.Duration `json:",default=500ms"`
 	IgnoreContentMethods []string      `json:",optional"`
 }
 
@@ -63,7 +63,8 @@ func UnaryStatInterceptor(metrics *stat.Metrics, conf StatConf) grpc.UnaryServer
 }
 
 func isSlow(duration, durationThreshold time.Duration) bool {
-	return durationThreshold > 0 && duration > durationThreshold
+	return duration > slowThreshold.Load() ||
+		(durationThreshold > 0 && duration > durationThreshold)
 }
 
 func logDuration(ctx context.Context, method string, req any, duration time.Duration,

diff --git a/zrpc/internal/serverinterceptors/statinterceptor_test.go b/zrpc/internal/serverinterceptors/statinterceptor_test.go
@@ -229,7 +229,7 @@ func Test_isSlow(t *testing.T) {
 			args{
 				duration: time.Millisecond * 501,
 			},
-			false,
+			true,
 			nil,
 		},
 		{
@@ -251,7 +251,8 @@ func Test_isSlow(t *testing.T) {
 			t.Cleanup(func() {
 				slowThreshold = syncx.ForAtomicDuration(defaultSlowThreshold)
 			})
-			assert.Equalf(t, tt.want, isSlow(tt.args.duration, tt.args.staticSlowThreshold), "isSlow(%v, %v)", tt.args.duration, tt.args.staticSlowThreshold)
+			assert.Equalf(t, tt.want, isSlow(tt.args.duration, tt.args.staticSlowThreshold),
+				"isSlow(%v, %v)", tt.args.duration, tt.args.staticSlowThreshold)
 		})
 	}
 }