fix(auth): refix issue #1997

[ymc9]

fixes #2019

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the internal documentation, business logic, and testing components. In the runtime package, the comment for the foreignKeyMapping property in the FieldInfo type has been revised. In addition, the default authentication handler’s logic was simplified by removing an unnecessary condition, thereby adjusting the way foreign key defaults are assigned during nested creations. A new regression test file has also been added to verify schema integrity and ensure that relationships among multiple models work as expected.

Changes

File(s)	Change Summary
packages/runtime/src/cross/model-meta.ts	Updated the comment for foreignKeyMapping in FieldInfo from "Mapping from foreign key field names to relation field names. Only available on relation fields." to "Mapping from relation's pk to fk. Only available on relation fields."
packages/runtime/src/enhancements/node/default-auth.ts	Simplified the logic in the DefaultAuthHandler by removing the nesting path length check. The back link verification now directly checks for existence and adjusts the early return condition based on whether the current field is present in the foreign key mapping.
tests/regression/tests/issue-2019.test.ts	Introduced a new regression test file to validate a multifaceted database schema. The test covers creation of tenants, users, posts, and related entities to ensure that relationships and data integrity constraints are correctly enforced.

Sequence Diagram(s)

sequenceDiagram
    participant Request as Nested Create Request
    participant AuthHandler as DefaultAuthHandler
    Request->>AuthHandler: Begin nested record creation
    AuthHandler->>AuthHandler: Check for back link existence
    alt Back link exists
        AuthHandler->>AuthHandler: Evaluate if current field is in FK mapping
        alt Field exists in mapping
            AuthHandler-->>Request: Return early (skip default assignment)
        else Field not in mapping
            AuthHandler->>AuthHandler: Evaluate opposite relation field
            AuthHandler-->>Request: Set default foreign key value accordingly
        end
    else No back link
        AuthHandler-->>Request: Proceed with standard default assignment
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0d25d4 and 91bedcd.

📒 Files selected for processing (3)

• packages/runtime/src/cross/model-meta.ts (1 hunks)
• packages/runtime/src/enhancements/node/default-auth.ts (1 hunks)
• tests/regression/tests/issue-2019.test.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: build-test (20.x)
• GitHub Check: dependency-review
• GitHub Check: build-test (20.x)
• GitHub Check: build-test (20.x)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: OSSAR-Scan

🔇 Additional comments (3)

packages/runtime/src/enhancements/node/default-auth.ts (1)

129-147: Logic simplification looks good

The condition check has been simplified to focus on the existence of a backLink in the context, which is clearer and more direct. The updated code correctly evaluates the opposite relation field's foreignKeyMapping to determine whether to apply default values.

packages/runtime/src/cross/model-meta.ts (1)

89-89: Comment clarification is accurate

This update provides a more precise description of what the foreignKeyMapping property represents - it maps from the relation's primary key to the foreign key, not the other way around.

tests/regression/tests/issue-2019.test.ts (1)

1-87: Good regression test for issue #2019

This test effectively validates the fix by creating a nested structure with foreign key relationships and verifying that the tenantId is correctly propagated during nested creation.

The test covers:

1. A complex schema with multiple models and relationships
2. Default value handling with auth() context
3. Nested creation with foreign key propagation

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.