Merge branch 'hotfix/3286'

Close zendframework/zendframework#3286

src/Node.php

@@ -128,9 +128,9 @@ public function getLdap()
         if ($this->ldap === null) {
             throw new Exception\LdapException(null, 'No LDAP connection specified.',
                 Exception\LdapException::LDAP_OTHER);
-        } else {
-            return $this->ldap;
         }
+
+        return $this->ldap;
     }
 
     /**
@@ -816,9 +816,9 @@ protected function assertChangeableAttribute($name)
             throw new Exception\LdapException(null, 'Cannot change attribute because it\'s part of the RDN');
         } elseif (in_array($name, static::$systemAttributes)) {
             throw new Exception\LdapException(null, 'Cannot change attribute because it\'s read-only');
-        } else {
-            return true;
         }
+
+        return true;
     }
 
     /**

src/Node/AbstractNode.php

@@ -259,9 +259,9 @@ public function getData($includeSystemAttributes = true)
                 }
             }
             return $data;
-        } else {
-            return $this->currentData;
         }
+
+        return $this->currentData;
     }
 
     /**
@@ -286,9 +286,9 @@ public function existsAttribute($name, $emptyExists = false)
             }
 
             return count($this->currentData[$name]) > 0;
-        } else {
-            return false;
         }
+
+        return false;
     }
 
     /**
@@ -317,9 +317,9 @@ public function getAttribute($name, $index = null)
     {
         if ($name == 'dn') {
             return $this->getDnString();
-        } else {
-            return Ldap\Attribute::getAttribute($this->currentData, $name, $index);
         }
+
+        return Ldap\Attribute::getAttribute($this->currentData, $name, $index);
     }
 
     /**

src/Node/ChildrenIterator.php

@@ -112,9 +112,9 @@ public function hasChildren()
     {
         if ($this->current() instanceof Ldap\Node) {
             return $this->current()->hasChildren();
-        } else {
-            return false;
         }
+
+        return false;
     }
 
     /**
@@ -126,9 +126,9 @@ public function getChildren()
     {
         if ($this->current() instanceof Ldap\Node) {
             return $this->current()->getChildren();
-        } else {
-            return null;
         }
+
+        return null;
     }
 
     /**
@@ -142,9 +142,9 @@ public function offsetGet($rdn)
     {
         if ($this->offsetExists($rdn)) {
             return $this->data[$rdn];
-        } else {
-            return null;
         }
+
+        return null;
     }
 
     /**

src/Node/RootDse.php

@@ -44,9 +44,9 @@ public static function create(Ldap\Ldap $ldap)
             && $data['structuralobjectclass'][0] === 'OpenLDAProotDSE'
         ) {
             return new RootDse\OpenLdap($dn, $data);
-        } else {
-            return new self($dn, $data);
         }
+
+        return new self($dn, $data);
     }
 
     /**

src/Node/Schema/AbstractItem.php

@@ -71,9 +71,9 @@ public function __get($name)
     {
         if (array_key_exists($name, $this->data)) {
             return $this->data[$name];
-        } else {
-            return null;
         }
+
+        return null;
     }
 
     /**

src/Node/Schema/AttributeType/OpenLdap.php

@@ -56,9 +56,9 @@ public function getSyntax()
             } else {
                 return $parent->getSyntax();
             }
-        } else {
-            return $this->syntax;
         }
+
+        return $this->syntax;
     }
 
     /**
@@ -76,9 +76,9 @@ public function getMaxLength()
             } else {
                 return $parent->getMaxLength();
             }
-        } else {
-            return (int) $maxLength;
         }
+
+        return (int) $maxLength;
     }
 
     /**

src/Node/Schema/ObjectClass/OpenLdap.php

@@ -128,9 +128,9 @@ public function getType()
             return Schema::OBJECTCLASS_TYPE_ABSTRACT;
         } elseif ($this->auxiliary) {
             return Schema::OBJECTCLASS_TYPE_AUXILIARY;
-        } else {
-            return Schema::OBJECTCLASS_TYPE_UNKNOWN;
         }
+
+        return Schema::OBJECTCLASS_TYPE_UNKNOWN;
     }
 
     /**