gff/directive_buf/value: Add conversion from string

zaeleus · Dec 5, 2024 · edf6970 · edf6970
1 parent 955d8c7
commit edf6970
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/noodles-gff/src/directive_buf.rs b/noodles-gff/src/directive_buf.rs
@@ -113,7 +113,7 @@ impl FromStr for DirectiveBuf {
                 .and_then(|s| s.parse().map_err(ParseError::InvalidGenomeBuild))
                 .map(Value::GenomeBuild)
                 .map(Some)?,
-            _ => components.next().map(|s| Value::String(s.into())),
+            _ => components.next().map(Value::from),
         };
 
         Ok(Self {
@@ -133,10 +133,7 @@ mod tests {
 
         assert_eq!(
             "##noodles gff".parse(),
-            Ok(DirectiveBuf::new(
-                "noodles",
-                Some(Value::String(String::from("gff"))),
-            )),
+            Ok(DirectiveBuf::new("noodles", Some(Value::from("gff")))),
         );
     }
 }
diff --git a/noodles-gff/src/directive_buf/value.rs b/noodles-gff/src/directive_buf/value.rs
@@ -20,3 +20,15 @@ pub enum Value {
     /// Any other directive value.
     String(String),
 }
+
+impl From<&str> for Value {
+    fn from(s: &str) -> Self {
+        Value::String(s.into())
+    }
+}
+
+impl From<String> for Value {
+    fn from(s: String) -> Self {
+        Value::String(s)
+    }
+}
diff --git a/noodles-gff/src/io/writer/line/directive.rs b/noodles-gff/src/io/writer/line/directive.rs
@@ -125,7 +125,7 @@ mod tests {
 
         t(
             &mut buf,
-            &DirectiveBuf::new("noodles", Some(Value::String(String::from("gff")))),
+            &DirectiveBuf::new("noodles", Some(Value::from("gff"))),
             b"##noodles gff",
         )?;